Skip to content

Make vcpkg overlay directories configurable#352

Merged
smvv merged 2 commits into
duckdb:mainfrom
mbrobbel:vcpkg-overlay-inputs
Apr 17, 2026
Merged

Make vcpkg overlay directories configurable#352
smvv merged 2 commits into
duckdb:mainfrom
mbrobbel:vcpkg-overlay-inputs

Conversation

@mbrobbel

@mbrobbel mbrobbel commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add vcpkg_overlay_ports and vcpkg_overlay_triplets workflow inputs to allow extensions to override the default vcpkg overlay directories
  • Defaults match the current hardcoded paths, so existing builds are unaffected
  • Also fixes a typo in the triplets path (extensions-ci-toolsextension-ci-tools)

Test plan

  • Verify existing builds work without specifying the new inputs (defaults should match current behavior)
  • Test overriding vcpkg_overlay_ports and vcpkg_overlay_triplets with custom paths

🤖 Created by Claude

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Add `vcpkg_overlay_ports` and `vcpkg_overlay_triplets` workflow inputs
so extensions can override the default overlay directories. Defaults
match the current hardcoded paths, keeping existing builds unaffected.

Also fixes a typo in the triplets path (`extensions-ci-tools` →
`extension-ci-tools`).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@samansmink samansmink requested a review from smvv April 15, 2026 14:23

@smvv smvv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smvv smvv merged commit 1d3a50b into duckdb:main Apr 17, 2026
4 checks passed
@mbrobbel mbrobbel deleted the vcpkg-overlay-inputs branch April 17, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants